chore(web-tests): use is-ci instead of shell#784
Merged
colinaaa merged 1 commit intolynx-family:mainfrom May 13, 2025
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 3.35kB (0.52%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @lynx-js/example-react-lynx-cjsAssets Changed:
|
CodSpeed Performance ReportMerging #784 will not alter performanceComparing Summary
|
PupilTong
approved these changes
May 13, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2025
## Summary Fix [Rspack EcoSystem CI failure](https://github.com/web-infra-dev/rspack/actions/runs/14986731044/job/42102260301) (since `CI` could be something like `true` or `github`). This would also make web-tests:build work on Windows. ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Rspack EcoSystem CI failure (since
CIcould be something liketrueorgithub).This would also make web-tests:build work on Windows.
Checklist